RFR: 8349748: [leyden] ciEnv::register_method should lock the correct queue lock

Vladimir Kozlov kvn at openjdk.org
Tue Feb 11 16:28:23 UTC 2025


On Mon, 10 Feb 2025 17:53:39 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Mainline code locks `MethodCompileQueue_lock` in `ciEnv::register_method`. But with Leyden-s `UseGlobalCompileQueueLock = false`, we have separate locks, per compile queue. So it seems to stand to reason we should be locking those locks, not a global one.
> 
> I have not been able to attribute this gap to any bug or performance issue, but I think we better fix this proactively.

Good.

-------------

Marked as reviewed by kvn (Committer).

PR Review: https://git.openjdk.org/leyden/pull/37#pullrequestreview-2609295225


More information about the leyden-dev mailing list