RFR: 8349539: [leyden] Allow dumping nmethods that reference archived hidden klasses [v4]

[Aleksey Shipilev]

On Thu, 6 Feb 2025 22:00:38 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'premain' into JDK-8349539-allow-hidden
>>  - Merge branch 'premain' into JDK-8349539-allow-hidden
>>  - Moving the check around
>>  - Fix
>
> I agree that the restriction for hidden classes can be lifted.
> 
> But there are non-default modes where it still matters (`UseMetadataPointers == true`). 
> I suggest to keep `klass->is_hidden()` check, but move it down to guard symbolic resolution case.

Are we good with this, @iwanowww? Is this the correct place to move the check?

-------------

PR Comment: https://git.openjdk.org/leyden/pull/33#issuecomment-2651371189