RFR: 8349814: [leyden] Avoid uncommon traps in preload code [v2]

[Vladimir Ivanov]

On Tue, 11 Feb 2025 20:44:41 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'premain' into JDK-8349814-preload-avoid-uncommon-traps
>>  - Comment
>>  - Fix
>
> src/hotspot/share/runtime/deoptimization.cpp line 2130:
> 
>> 2128:                                 tm->name_and_sig_as_C_string(), trap_bci, nm->compiler_name());
>> 2129: 
>> 2130:       if (nm->preloaded() && (action != Action_none)) {
> 
> At some point, I added SCC-related info to `TraceDeoptimization` output [1], but it turns out I didn't upstream it. (I had a script which parsed the log and aggregated information about deopts in archived code.) 
> 
> Maybe it's better to upstream it instead of introducing such adhoc logging.
> 
> [1] https://github.com/iwanowww/leyden/blame/premain-precompile/src/hotspot/share/runtime/deoptimization.cpp#L2151

But speaking of monitoring for uncommon traps in generated code: the ultimate goal may be to completely eliminate uncommon traps in preloaded code. In that respect, it's more interesting to monitor for all uncommon traps issued during compilation rather than those hit at runtime. 

For C2 it's `GraphKit::uncommon_trap()`, so I suggest to move the code there. Also, additional information about compilation (id) and location (jvms info) is useful to pin down the root cause.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/38#discussion_r1951585460