RFR: 8349905: [leyden] Make SCCache depend on CDS build feature

Aleksey Shipilev shade at openjdk.org
Wed Feb 12 17:42:24 UTC 2025


On Wed, 12 Feb 2025 17:03:55 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> As we are moving more SCCache code to CDS archives, we need to start depending on CDS feature being enabled during the build to get access to SCCache stuff. A common configuration where CDS is not available is Minimal VM.
>
> make/hotspot/lib/JvmFeatures.gmk line 126:
> 
>> 124:       classLoaderDataShared.cpp \
>> 125:       classLoaderExt.cpp \
>> 126:       precompiler.cpp \
> 
> Oh nice! I didn't know about this. Yesterday I was sprinkling INCLUDE_CDS in SCCache.cpp because it was getting compiled in the minimal config.

Yup. This is a nuclear option in the build system! For your other PR, you might need to stub out more things with `NOT_CDS*` in `SCCache.hpp` to make things work.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/40#discussion_r1953128812


More information about the leyden-dev mailing list