RFR: Store AOT code in cached code region of AOT cache [v7]

[Ashutosh Mehra]

On Thu, 13 Feb 2025 05:20:36 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix another comment
>>    
>>    Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>>  - Missing "AOT" in the comment
>>    
>>    Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/hotspot/share/cds/cdsAccess.hpp line 59:
> 
>> 57:   static void test_heap_access_api() NOT_CDS_JAVA_HEAP_RETURN;
>> 58: 
>> 59:   static void* allocate_from_code_cache(size_t size) NOT_CDS_JAVA_HEAP_RETURN_(nullptr);
> 
> I think the following functions should be marked as `NOT_CDS_RETURN`. In the cpp file, they should be moved outside of the `INCLUDE_CDS_JAVA_HEAP` block:
> 
> 
> void* CDSAccess::allocate_from_code_cache(size_t size)
> size_t CDSAccess::get_cached_code_size()
> void CDSAccess::set_cached_code_size(size_t sz)
> bool CDSAccess::is_cached_code_region_empty()
> bool CDSAccess::map_cached_code(ReservedSpace rs)

yup, I agree

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/39#discussion_r1954705262