RFR: 8350115: [leyden] Clean up name_and_sig_as_C_string uses
Ashutosh Mehra
asmehra at openjdk.org
Fri Feb 14 17:39:19 UTC 2025
On Fri, 14 Feb 2025 16:26:05 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Now that we have optimized a lot of unnecessary compilations, profiles show that various `name_and_sig_as_C_string` are taking about 1.2% in Leyden benchmark profiles. We should sweep those up into conditional log statements and/or common the paths where we actually need these names outside of logging.
>
> After this fix, the profile impact of `name_and_sig_as_C_string` is `<0.05%`.
>
> Performance impact on benchmarks is currently hidden by benchmark noise.
lgtm
-------------
Marked as reviewed by asmehra (Committer).
PR Review: https://git.openjdk.org/leyden/pull/43#pullrequestreview-2618433248
More information about the leyden-dev
mailing list