RFR: 8341587: [premain] Support Soft/Weak Reference in AOT cache

[Ioi Lam]

On Wed, 12 Feb 2025 22:16:04 GMT, Mat Carter <macarte at openjdk.org> wrote:

> Add support to the AOT cache for References (soft, weak and phantom)
> Remove the workarounds that were added because References weren't supported
> 
> Confirmed from logs that References are stored in the cache correctly
> 
> All demos run successfully on osx

This looks good. I ran all the CDS tests and found only one crash with SpringClinic due to [JDK-8350148](https://bugs.openjdk.org/browse/JDK-8350148). I will try to fix this bug first before this PR is integrated.

src/hotspot/share/cds/metaspaceShared.cpp line 1025:

> 1023:       // updated concurrently when we are saving their contents into a side table.
> 1024:       // Now that we don't make a side table, is this needed for the remaining call
> 1025:       // to resetArchivedStates

I think comments from 1022-1023 can be removed. The assert should be moved to just after line 1006:


#if INCLUDE_CDS_JAVA_HEAP
  if (CDSConfig::is_dumping_heap()) {
    // We will reset some important global states in a few system classes. If we have concurrent
    // Java threads, they will either fail as a result, or resuscitate these states. Neither is
    // desirable.
    assert(CDSConfig::allow_only_single_java_thread(), "Required");

-------------

PR Review: https://git.openjdk.org/leyden/pull/41#pullrequestreview-2619311769
PR Review Comment: https://git.openjdk.org/leyden/pull/41#discussion_r1957033597