RFR: 8341587: [premain] Support Soft/Weak Reference in AOT cache

[Mat Carter]

On Sat, 15 Feb 2025 04:58:25 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Add support to the AOT cache for References (soft, weak and phantom)
>> Remove the workarounds that were added because References weren't supported
>> 
>> Confirmed from logs that References are stored in the cache correctly
>> 
>> All demos run successfully on osx
>
> src/hotspot/share/cds/metaspaceShared.cpp line 1025:
> 
>> 1023:       // updated concurrently when we are saving their contents into a side table.
>> 1024:       // Now that we don't make a side table, is this needed for the remaining call
>> 1025:       // to resetArchivedStates
> 
> I think comments from 1022-1023 can be removed. The assert should be moved to just after line 1006:
> 
> 
> #if INCLUDE_CDS_JAVA_HEAP
>   if (CDSConfig::is_dumping_heap()) {
>     // We will reset some important global states in a few system classes. If we have concurrent
>     // Java threads, they will either fail as a result, or resuscitate these states. Neither is
>     // desirable.
>     assert(CDSConfig::allow_only_single_java_thread(), "Required");

Agreed, changes made

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/41#discussion_r1960731065