RFR: 8341587: [premain] Support Soft/Weak Reference in AOT cache

[Mat Carter]

On Wed, 19 Feb 2025 02:16:22 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Add support to the AOT cache for References (soft, weak and phantom)
>> Remove the workarounds that were added because References weren't supported
>> 
>> Confirmed from logs that References are stored in the cache correctly
>> 
>> All demos run successfully on osx
>
> src/java.base/share/classes/java/lang/invoke/MethodTypeForm.java line 134:
> 
>> 132:     @SuppressWarnings({"rawtypes", "unchecked"})
>> 133:     public LambdaForm cachedLambdaForm(int which) {
>> 134:         Object entry = lambdaForms[which];
> 
> I recommend restoring the static types of the arrays to `SoftReference<MethodHandle>[]` unless there is extra overhead from loading/initialization of `SoftReference` class.

I tried this before but then 'this.methodHandles = new SoftReference<MethodHandle>[MH_LIMIT];' is not allowed due to the error 'generic array creation'.  I looked at allocating using ArrayList<>(initialCapacity) as they are backed. with Object[], but then we have to add range checks on the reads to avoid IndexOutOfBounds or set a null entry at (initialCapacity-1); unless someone can suggest a better implementation I'm inclined to let it stand

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/41#discussion_r1962046281