RFR: Fix SCCache stats logged on exit [v4]

Vladimir Kozlov kvn at openjdk.org
Thu Feb 20 23:03:43 UTC 2025


On Thu, 20 Feb 2025 22:45:15 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> The count of various SCCEntry kinds is not correctly computed. This patch fixes it.
>> This code was introduced as part of i2c2i adapters and was picked up from Andrew Dinn's work on storing stub and blobs. Clearly I messed it up.
>> The patch also computes and shows the counts for old entries and new entries separately. Though not useful for now, but in incremental workflow it may be helpful to distinguish between the old and new entries.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Display stats only if not 0
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

Nice.

Looks like you have tabs instead of spaces in few places.

-------------

Marked as reviewed by kvn (Committer).

PR Review: https://git.openjdk.org/leyden/pull/42#pullrequestreview-2631375417
PR Comment: https://git.openjdk.org/leyden/pull/42#issuecomment-2672894405


More information about the leyden-dev mailing list