RFR: 8349814: [leyden] Reduce uncommon traps in preload code [v2]

[Aleksey Shipilev]

On Tue, 11 Feb 2025 17:06:32 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase.
>
> src/hotspot/share/compiler/precompiler.cpp line 235:
> 
>> 233: 
>> 234:     {
>> 235:       // For preload code, avoid any uncommon traps.
> 
> Why don't you instrument `Compile::too_many_traps()` instead? (Check for compilation reason and unconditionally return true when compiling code for preloading.)  
> 
> Also, it would be useful to make new logic conditional (controlled by a diagnostic flag). It would make it easier to measure deoptimization-induced performance effects at runtime.

Yes, good ideas, done so.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/38#discussion_r1965425814