RFR: 8349814: [leyden] Reduce uncommon traps in preload code [v3]

[Aleksey Shipilev]

On Mon, 24 Feb 2025 08:03:47 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Shuffle things around to capture more cases
>>  - Comment
>>  - Fix
>
> src/hotspot/share/runtime/deoptimization.cpp line 2134:
> 
>> 2132:         // Compiler logs all uncommon traps with -Xlog:scc. That log is noisy, and some traps may be
>> 2133:         // legitimate. Here, we log the problems that really caused the deopts at runtime.
>> 2134:         log_warning(deoptimization)("In preload code: reason=%s action=%s method=%s",
> 
> Does it warrant a warning though? It can become quite noisy and users don't have any way to address the problem. `log_info`    looks a better fit here (and, probably, narrow the category to `scc+deoptimization`).

Doing these as `warnings` are my habit when doing high-perf prototypes. But yeah, we can do `info` instead, and I'll just enable the logging in my perf scripts.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/38#discussion_r1967328814