RFR: Save/load i2c2i adapters [v6]

[Ashutosh Mehra]

On Wed, 8 Jan 2025 23:05:55 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>>> > @iklam can you run this patch through our internal testing?
>>> 
>>> OK I will do it.
>> 
>> I am seeing new failures on aarch64 only. x64 seems fine:
>> 
>> 
>> runtime/cds/appcds/applications/JavacBench.java#leyden			macosx-aarch64-debug
>> runtime/cds/appcds/applications/MicronautFirstApp.java#leyden		macosx-aarch64-debug
>> runtime/cds/appcds/applications/MicronautFirstApp.java#leyden		linux-aarch64-open
>> runtime/cds/appcds/applications/MicronautFirstApp.java#leyden		linux-aarch64-debug
>> runtime/cds/appcds/applications/QuarkusGettingStarted.java#leyden       linux-aarch64-debug
>> 
>> 
>> Here's the hs_err. This happens in the final production run. 
>> 
>> 
>> #  SIGSEGV (0xb) at pc=0x0000ffff89976650, pid=3238003, tid=3238006
>> #
>> # JRE version: Java(TM) SE Runtime Environment (24.0) (fastdebug build 24-internal-2025-01-07-1758562.ioi.lam.le4)
>> # Java VM: Java HotSpot(TM) 64-Bit Server VM (fastdebug 24-internal-2025-01-07-1758562.ioi.lam.le4, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-aarch64)
>> # Problematic frame:
>> # v  ~AdapterBlob 0x0000ffff83d1b0d8
>> 
>> ---------------  S U M M A R Y ------------
>> 
>> Command Line: -XX:MaxRAMPercentage=6.25 -Dtest.boot.jdk=/opt/mach5/mesos/work_dir/jib-master/install/jdk/23/37/bundles/linux-aarch64/jdk-23_linux-aarch64_bin.tar.gz/jdk-23 -Djava.io.tmpdir=/opt/mach5/mesos/work_dir/slaves/b733f181-520a-4536-86fc-7df55263c942-S3131/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/4ab6604d-6790-4797-a358-fcfe3a5e2cfe/runs/b53804f1-a345-47c7-9bed-24313dccd140/testoutput/test-support/jtreg_open_test_hotspot_jtreg_hotspot_tier2_runtime/tmp -DautoQuit=true -Dmicronaut.server.port=0 -XX:+IgnoreUnrecognizedVMOptions -XX:-VerifyDependencies -XX:+UnlockDiagnosticVMOptions -XX:VerifyArchivedFields=2 -Xlog:cds:file=MicronautFirstApp.production.log::filesize=0 -XX:CacheDataStore=MicronautFirstApp.cds -Xlog:scc=error example.micronaut.Application
>
>> @iklam I have tried reproducing these failures on an linux-aarch64 (fedora 40) system but the tests always pass. I have run them multiple times using fastdebug and release build but didn't get any failure.
>> 
>> Are these failure reproducible every time in your testing, or are they intermittent? Which Linux distro were this tests run on? Also, can you share the backtrace for the crash.
> 
> I got those crashes from our CI pipeline. Let me try to run the tests manually on linux-aarch hosts and see if I can reproduce the problems.

@iklam @vnkozlov there have been some changes since last review to fix a number of bugs in this PR. So I am requesting another review.

-------------

PR Comment: https://git.openjdk.org/leyden/pull/25#issuecomment-2622522530