RFR: Store cpu features in AOTCodeCache header
Vladimir Kozlov
kvn at openjdk.org
Mon Jul 14 19:38:56 UTC 2025
On Mon, 14 Jul 2025 19:19:31 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:
>> src/hotspot/cpu/x86/vm_version_x86.hpp line 373:
>>
>>> 371: decl(FXSR, fxsr, 2) \
>>> 372: decl(HT, ht, 3) \
>>> 373: \
>>
>> Please, revert alignment change to reduce size of changes. We can do it in mainline later.
>
> This change is not about alignment, but removing the quotes around the cpu feature names and use XSTR macro in DECLARE_CPU_FEATURE_NAME macros instead. Any change in alignment is the consequence of that.
> Do you want me to go back to using quotes and remove XSTR usage?
Okay, I missed that. Keep XSTR. Why aarch64 code does not use XSTR?
-------------
PR Review Comment: https://git.openjdk.org/leyden/pull/84#discussion_r2205662340
More information about the leyden-dev
mailing list