RFR: 8362558: [Leyden] fatal error: New workflow: should not compile code for unarchived class: UnsupportedBSMs$$Lambda/0... [v2]

[Ioi Lam]

On Mon, 21 Jul 2025 18:45:24 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @vnkozlov comments
>
> src/hotspot/share/ci/ciEnv.cpp line 837:
> 
>> 835:     Method* adapter = cpool->resolved_indy_entry_at(index)->method();
>> 836:     if (is_precompiled()) {
>> 837:         ResolvedIndyEntry* indy_info = cpool()->resolved_indy_entry_at(index);
> 
> Can move `indy_info` up and use it in `adapter = ` expression too?
> 
> Do you need to use `()` for `cool()`? Other code does not use it.

I changed `cpool()->` to `cpool->`.

Do you mean this:


if (!AOTConstantPoolResolver::is_resolution_deterministic(cpool(),
         cpool->resolved_indy_entry_at(index)->constant_pool_index())) { 
    adapter = nullptr;
}


I think that will make the code hard to read as you see two "index" in a row.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/87#discussion_r2220258848