RFR: 8362558: [Leyden] fatal error: New workflow: should not compile code for unarchived class: UnsupportedBSMs$$Lambda/0... [v2]

[Ioi Lam]

On Mon, 21 Jul 2025 20:44:59 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> I changed `cpool()->` to `cpool->`.
>> 
>> Do you mean this:
>> 
>> 
>> if (!AOTConstantPoolResolver::is_resolution_deterministic(cpool(),
>>          cpool->resolved_indy_entry_at(index)->constant_pool_index())) { 
>>     adapter = nullptr;
>> }
>> 
>> 
>> I think that will make the code hard to read as you see two "index" in a row.
>
> I ment to move up not down:
> 
>    ResolvedIndyEntry* indy_info = cpool->resolved_indy_entry_at(index);
>    Method* adapter = indy_info->method();
> #if INCLUDE_CDS
>     if (is_precompiled() && !AOTConstantPoolResolver::is_resolution_deterministic(cpool(), indy_info->constant_pool_index())) {

But `indy_info` is not used outside of that scope, so we shouldn't move it up.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/87#discussion_r2220345256