RFR: 8362657: Make tables used in AOT assembly phase GC-safe [v2]

[Aleksey Shipilev]

On Tue, 22 Jul 2025 02:32:44 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This fixes crashes when using `-Xlog:aot+map=trace,aot+map+oops=trace:file=aot.oops.txt:none:filesize=0` during the assembly phase.
>> 
>> I basically changed a few raw `oop` pointers to `OopHandle`. I also simplified `ArchiveHeapWriter::is_marked_as_native_pointer()`.
>> 
>> Note that for `HeapShared::archived_object_cache()`, I calculate the hashcode using the raw oop. This way, we can avoid calling `oopDesc::identity_hash()` for every archived oops. As a result, when we use this table after exiting the CDS safepoint, we must rehash it. See changes in `ArchiveBuilder::CDSMapLogger::log()`.
>> 
>> - It might be alright to pre-calculate the identity hash of the archived oops in the assembly phase, but I think we should do that only if we find a reason to do so. We shouldn't do it just because it's convenient for implementing an internal table,
>
> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Fixed 32-bit builds
>  - Merge branch 'premain' into 8362657-make-aot-assembly-tables-gc-safe
>  - Fixed white spaces
>  - 8362657: Make tables used in AOT assembly phase GC-safe

OK, this looks fine.

-------------

Marked as reviewed by shade (Committer).

PR Review: https://git.openjdk.org/leyden/pull/86#pullrequestreview-3042866317