RFR: Store cpu features in AOTCodeCache header [v9]
Vladimir Kozlov
kvn at openjdk.org
Mon Jul 28 21:08:12 UTC 2025
On Mon, 28 Jul 2025 14:37:59 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:
>> This is the initial version of storing cpu features in the AOTCodeCache to verify runtime env has the same cpu capabilities as the assembly env. It covers both x86 and aarch64.
>> AOTCodeCache header is updated to store the cpu features in arch-dependent form (although its same for currently supported architectures - x86 and aarch64).
>>
>> It also fixes a bug - the `polling_page_vectors_safepoint_handler_blob` can be null if AVX is not present on a system. This causes crash as this blob's entry point is stored in the address table.
>> I came across this when I did the assembly run with -XX:UseAVX=0 option.
>
> Ashutosh Mehra has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>
> - Merge branch 'premain' into aot-cache-feature-flags
> - Fix incorrect return type
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
> - Fix whitespace issue
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
> - Add dianostic option AOTCodeCPUFeatureCheck to disable cpu feature check
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
> - Update cpu feature incompatibility test
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
> - Merge branch 'premain' into aot-cache-feature-flags
> - Add test to check cpu feature incompatibility
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
> - Ignore CPU_HT when storing cpu features in AOTCodeCache
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
> - Fix formatting of log messages
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
> - Restore changes deleted by mistake
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
> - ... and 6 more: https://git.openjdk.org/leyden/compare/392fbbb1...c9b8349c
Let me test your changes again with latest premain.
-------------
PR Comment: https://git.openjdk.org/leyden/pull/84#issuecomment-3129889232
More information about the leyden-dev
mailing list