RFR: Update nmethod caching and clean up unused/duplicate methods [v3]

Andrew Dinn adinn at openjdk.org
Thu Jun 5 13:26:17 UTC 2025


On Mon, 2 Jun 2025 14:51:47 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> This PR updates nmethod caching to be based on caching of CodeBlob. It also cleans up some dead code and duplicate methods.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove CodeBuffer::clear_strings() as the relevant destructors clear the
>   strings
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

src/hotspot/share/code/aotCodeCache.hpp line 193:

> 191:     _not_entrant  = false;
> 192:     _load_fail    = false;
> 193:     _ignore_decompile = true;

This leaves field `_ignore_decompile` uninitialized. Should you be setting it to `false` here?

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/71#discussion_r2128422781


More information about the leyden-dev mailing list