RFR: 8358343: [leyden] Drop notify_all in CompilationPolicyUtils::Queue::pop
Aleksey Shipilev
shade at openjdk.org
Fri Jun 6 06:57:09 UTC 2025
On Fri, 6 Jun 2025 03:22:05 GMT, Igor Veresov <iveresov at openjdk.org> wrote:
> Is there a reason why can't we just do the processing work in the thread calling the flush instead of waiting for the replay thread? That is, why not make it be like this:
You tell me :) I guess one upside of current code is to leave draining/processing in one place/thread, and thus never run into false positives/negatives due to diagnostic code (this hunk, gated by `-XX:+AOTVerifyTrainingData`) doing something that production code does not. So I mildly prefer it in current form. I can change it, if you want.
-------------
PR Comment: https://git.openjdk.org/leyden/pull/74#issuecomment-2948283345
More information about the leyden-dev
mailing list