RFR: Remove Leyden experimental workflow

[Vladimir Kozlov]

On Fri, 27 Jun 2025 17:28:30 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Remove the Leyden experimental workflow: `-XX:CacheDataStore` switch and friends.
> 
> We should be using the standard JEP 483/514 workflow for AOT cache.

Few comments otherwise it is good. Please wait until mainline is merged.

Please enable GHA testing

src/hotspot/share/cds/cdsConfig.cpp line 395:

> 393:   if (FLAG_IS_DEFAULT(AOTCache) && AOTStubCaching) {
> 394:     log_debug(aot,codecache,init)("AOTCache is not specified - AOTStubCaching is ignored");
> 395:   }

Correct removal. This was incorrect merge from mainline.

src/hotspot/share/cds/cdsConfig.cpp line 467:

> 465:   }
> 466:   if (FLAG_IS_DEFAULT(AOTCache) && AOTStubCaching) {
> 467:     log_debug(aot,codecache,init)("AOTCache is not specified - AOTStubCaching is ignored");

You can remove these checks. There is similar check in  `AOTCodeCache::initialize()` for all types of AOT code.

-------------

PR Review: https://git.openjdk.org/leyden/pull/83#pullrequestreview-2967705431
PR Comment: https://git.openjdk.org/leyden/pull/83#issuecomment-3014180472
PR Review Comment: https://git.openjdk.org/leyden/pull/83#discussion_r2172719582
PR Review Comment: https://git.openjdk.org/leyden/pull/83#discussion_r2172729434