RFR: 8347755: Support static library in jmod [v6]
Magnus Ihse Bursie
ihse at openjdk.org
Fri Mar 14 10:03:28 UTC 2025
On Fri, 14 Mar 2025 04:42:49 GMT, Henry Jen <henryjen at openjdk.org> wrote:
>> This PR add --static-libs option to the jmod tool, it's basically mirroring --libs option to support adding a new section of static archive into the jmod file under the new section `static-lib`.
>>
>> The JMOD magic header contains a MAJOR and MINOR version, we bump up the MINOR version if the --static-libs option is specified; otherwise, keep the MINOR version as 1. This allow created JMOD file without the newly supported static-lib section to continue be consumed by earlier version of jmod tool.
>>
>> Also fix the formatting for _hermetic_jdk_jimage_offset, which is a julong(uint64_t) as unsigned long long on MacOS, thus need to use %llu.
>
> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>
> Add hotspot static libs to java.base-static-jmod
`static-lib/module-included-libs.txt` should not be included. It is a built-time support file. I guess this happens since you re-used an existing directory structure that was only used for build support files before. The proper fix is to make sure this file ends up in a different directory.
-------------
PR Comment: https://git.openjdk.org/leyden/pull/46#issuecomment-2724209876
More information about the leyden-dev
mailing list