RFR: 8351965: [leyden] Skip installing C2 AOT code if C2 precompiled AOT code trapped [v3]

Aleksey Shipilev shade at openjdk.org
Tue Mar 18 19:42:05 UTC 2025


On Tue, 18 Mar 2025 19:28:24 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Also mark entry as non-entrant
>
> src/hotspot/share/ci/ciEnv.cpp line 1083:
> 
>> 1081:       if (mdo != nullptr && _inc_decompile_count_on_failure) {
>> 1082:         mdo->inc_decompile_count();
>> 1083:         if (nm != nullptr && nm->preloaded()) {
> 
> `nm` is not set yet here. You need to check `preload`

Right. Actually, I think I need to invalidate the A4 SCC entry anyway, so I can just do that on trapping path, and avoid extending any MDOs. This also avoids any attempt to actually load A4 code, touching any queues, or interfering with compilation policies. I pushed a new version, going to measure its perf tomorrow.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/48#discussion_r2001864191


More information about the leyden-dev mailing list