RFR: 8351493: Revert build changes that are no longer needed [v2]

Jiangli Zhou jiangli at openjdk.org
Thu Mar 20 16:19:29 UTC 2025


On Wed, 19 Mar 2025 18:33:34 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> @jianglizhou I'd like your review as well, please?
>
> @magicus Apologize for the delay, as I didn't realize that you were looking for review on the change. The removal looks fine to me. I initially added `--with-static-java` to explicitly build static libraries that could be handled as system provided instead of bundled by default. I haven't removed it as I was still considering (in background) if it would be needed. We can always add a new flag when we identify the usages.

> @jianglizhou
> 
> > [...] explicitly build static libraries that could be handled as system provided instead of bundled by default.
> 
> I'm not sure what you mean by this?

This is related to the libraries setup by `autoconf/lib-bundled.m4`. I think `libharfbuzz` is default to system at some point of time. The library is not built from the source included in the JDK if system provided is used. For static support, we want to produce all libs in `static-libs` as we don't know if the users require the lib or not. It then has the same complexity as the "optional" static library (e.g. `libjsig.a`) that we recently discussed.

-------------

PR Comment: https://git.openjdk.org/leyden/pull/47#issuecomment-2741003959


More information about the leyden-dev mailing list