RFR: 8351965: [leyden] Skip C2 AOT code if C2 preload AOT code trapped [v2]
Vladimir Kozlov
kvn at openjdk.org
Fri Mar 21 23:30:28 UTC 2025
On Fri, 21 Mar 2025 22:58:42 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
> > Right. They are also compiled by the same compiler thread one after an other: [output.cpp#L3463](https://github.com/openjdk/leyden/blob/premain/src/hotspot/share/opto/output.cpp#L3463)
> > Note, Reason_PrecompileForPreload is used only for precompilation feature which we are not using for our workflow AFAICS.
>
> Actually, it's not how it works in 1-step workflow. `Reason_Precompile` and `Reason_PrecompileForPreload` are used for populating AOT code archive during assembly phase (see [precompiler.cpp#L138](https://github.com/openjdk/leyden/blob/premain/src/hotspot/share/compiler/precompiler.cpp#L138)).
Okay, I see it now: [metaspaceShared.cpp#L1116](https://github.com/openjdk/leyden/blob/premain/src/hotspot/share/cds/metaspaceShared.cpp#L1116)
Which means we compile "preload" and "normal" AOT code by different tasks and they may have different MDO due to pollution.
-------------
PR Comment: https://git.openjdk.org/leyden/pull/48#issuecomment-2744671920
More information about the leyden-dev
mailing list