RFR: 8355514: [premain] rename AOT code flags and adjust their ergonomic settings [v2]

Vladimir Kozlov kvn at openjdk.org
Mon May 5 17:15:57 UTC 2025


On Mon, 5 May 2025 10:50:46 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix printing condition
>
> Looks reasonable, with one nit:

Thank you @shipilev for review.

> src/hotspot/share/cds/metaspaceShared.cpp line 2139:
> 
>> 2137:     TrainingData::print_archived_training_data_on(tty);
>> 2138: 
>> 2139:     if (AOTCodeCache::is_dumping_code()) {
> 
> `LoadCachedCode` should be replaced with `is_using_code()`?

Fixed. It is `is_on_for_read()` actually since it prints all AOT code entries.

-------------

PR Comment: https://git.openjdk.org/leyden/pull/65#issuecomment-2851691643
PR Review Comment: https://git.openjdk.org/leyden/pull/65#discussion_r2073836513


More information about the leyden-dev mailing list