RFR: Some AOTCodeCache cleanup after merge from mainline [v2]

[Vladimir Kozlov]

On Wed, 14 May 2025 15:51:34 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> Additional cleanup following Vladimir's merge of mainline to premain.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix minimal variant compile failure
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

The test hit assert running CDS test on Windows. I attached hs_err_pid44896.log to [JDK-8354887](https://bugs.openjdk.org/browse/JDK-8354887) since this one does not have JBS entry.


#  Internal Error (\workspace\open\src\hotspot\share\utilities/globalDefinitions.hpp:439), pid=44896, tid=37336
#  assert(left >= right) failed: avoid underflow - left: 0x00000008003ba598 right: 0x000001ec04000000

V  [jvm.dll+0x173eb]  pointer_delta+0x4b  (globalDefinitions.hpp:439)
V  [jvm.dll+0x2a29a8]  AOTCodeCache::write_method+0x188  (aotCodeCache.cpp:2646)
V  [jvm.dll+0x2a2756]  AOTCodeCache::write_metadata+0xa6  (aotCodeCache.cpp:2516)
V  [jvm.dll+0x2a34fb]  AOTCodeCache::write_nmethod+0x7bb  (aotCodeCache.cpp:1720)
V  [jvm.dll+0x2a18e2]  AOTCodeCache::store_nmethod+0x122  (aotCodeCache.cpp:1564)
V  [jvm.dll+0x52dd98]  ciEnv::register_method+0x458  (ciEnv.cpp:1260)

-------------

PR Comment: https://git.openjdk.org/leyden/pull/66#issuecomment-2881171347