RFR: 8340474: [premain] Revert ArchiveRelocationMode back to 1 [v3]
Vladimir Kozlov
kvn at openjdk.org
Tue May 20 15:31:09 UTC 2025
On Tue, 20 May 2025 15:08:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Current Leyden premain repo has this change:
>>
>>
>> - product(int, ArchiveRelocationMode, 1, DIAGNOSTIC, \
>> + /*FIXME - AOT code has direct pointers to metadata that's not relocated*/ \
>> + product(int, ArchiveRelocationMode, 0, DIAGNOSTIC, \
>>
>>
>> We need to revert this to make sure we can compare the performance against mainline.
>>
>> Needs https://github.com/openjdk/leyden/pull/68 to work.
>>
>> Additional testing:
>> - [x] Linux x86_64 server fastdebug, `runtime/cds` after https://github.com/openjdk/leyden/pull/68
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'premain' into JDK-8340474-revert-archive-relocation-mode
> - Ditch relevant ProblemList entries as well
> - Fix
I applied your changes above Ashutosh's changes which I pulled from premain after his push.
Testing is good so far.
-------------
PR Comment: https://git.openjdk.org/leyden/pull/69#issuecomment-2894876813
More information about the leyden-dev
mailing list