RFR: 8368811: [Leyden] Use AOTRuntimeConstants table for card_table::_byte_map_base [v2]

[Vladimir Kozlov]

On Thu, 2 Oct 2025 08:43:25 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed card_shift from AOT constants table. Fixed minimal VM build.
>
> src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp line 68:
> 
>> 66: 
>> 67: #ifdef CARDTABLEBARRIERSET_POST_BARRIER_HELPER
>> 68:   assert(!aotCodeCache::is_on(), "this path is not implemented");
> 
> Suggestion:
> 
>   assert(!AOTCodeCache::is_on(), "this path is not implemented");

Goot catch. 32-bit ARM build failed because of this.

> src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp line 88:
> 
>> 86:     __ move(byte_map_base_adr, byte_map_base_reg);
>> 87:     LIR_Address* byte_map_base_indirect = new LIR_Address(byte_map_base_reg, 0, T_LONG);
>> 88:     //LIR_Opr byte_map_base = gen->new_pointer_register();
> 
> Do we need this comment?

Removed. I experimented with separate registers but reusing register (byte_map_base_reg) seems work too.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/102#discussion_r2399240598
PR Review Comment: https://git.openjdk.org/leyden/pull/102#discussion_r2399246826