RFR: 8368811: [Leyden] Use AOTRuntimeConstants table for card_table::_byte_map_base [v2]
    Vladimir Kozlov 
    kvn at openjdk.org
       
    Thu Oct  2 16:07:28 UTC 2025
    
    
  
On Thu, 2 Oct 2025 08:18:31 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed card_shift from AOT constants table. Fixed minimal VM build.
>
> src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp line 48:
> 
>> 46:   if (UseCondCardMark) {
>> 47:     Label L_already_dirty;
>> 48:     __ ldrb(rscratch2,  Address(obj, rscratch));
> 
> Do we need an extra precondition?
> `precond(!UseCondCardMark || rscratch != rscratch2)`
added
-------------
PR Review Comment: https://git.openjdk.org/leyden/pull/102#discussion_r2399316948
    
    
More information about the leyden-dev
mailing list