RFR: Refactor AOTCodeCache layout to store preload entries separately [v2]

Ashutosh Mehra asmehra at openjdk.org
Fri Sep 19 15:04:40 UTC 2025


On Fri, 19 Sep 2025 00:23:26 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove UseNewCode and older version of functions
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/hotspot/share/code/aotCodeCache.cpp line 1195:
> 
>> 1193:           // Skip not entrant preload code:
>> 1194:           // we can't pre-load code which may have failing dependencies.
>> 1195:           log_info(aot, codecache, exit)("Not entrant new entry comp_id: %d, comp_level: %d, hash: " UINT32_FORMAT_X_0 "%s",
> 
> Update message: "Skip not entrant preload code comp_id: ..."

Done

> src/hotspot/share/code/aotCodeCache.cpp line 1211:
> 
>> 1209:       uint size = align_up(entry->size(), DATA_ALIGNMENT);
>> 1210:       if (size > max_size) {
>> 1211:         max_size = size;
> 
> May be use separate `preload_max_size`

`max_size` is only used for logging maximum entry size. I think this is fine, unless we want to report largest preload entry as well.

> src/hotspot/share/code/aotCodeCache.hpp line 407:
> 
>> 405:                                        - _C2_blobs_count
>> 406:                                        - _adapters_count;
>> 407:                                   if (UseNewCode) count += _preload_entries_count;
> 
> We should not use experimental `UseNewCode` in final PR

Done

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/95#discussion_r2363212134
PR Review Comment: https://git.openjdk.org/leyden/pull/95#discussion_r2363211872
PR Review Comment: https://git.openjdk.org/leyden/pull/95#discussion_r2363212663


More information about the leyden-dev mailing list