RFR: 8368095: [leyden] Fix klass dependency recording [v3]
Aleksey Shipilev
shade at openjdk.org
Mon Sep 22 14:08:32 UTC 2025
On Mon, 22 Sep 2025 13:46:57 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
> Just out of interest, what's the difference if you add those object/klass deps only when they are new rather than already in the cache?
Ad-hoc culling of this PR shows this:
Uninitialized / total traps:
553 / 691 Current premain
138 / 276 This PR, but gating IK->is_initializing for deps recording [see above comment for fuller result]
45 / 179 This PR, but skipping recording on cache hits
2 / 129 This PR, but skipping object recording
2 / 118 This PR, full version
The performance improves as we go from top to bottom. Arguably, this might suggest we do not need to handle oop accesses, really, but there is a minor decrease to the number of total traps and what _looks to be_ a minor performance improvement on top.
-------------
PR Comment: https://git.openjdk.org/leyden/pull/97#issuecomment-3319248703
More information about the leyden-dev
mailing list