Crash on macosx-aarch64 when merging Leyden premain with mainline

[ioi.lam at oracle.com]

Thanks Vladimir for the patch. It fixes the crash.

I have now merged up to 
https://github.com/openjdk/jdk/commit/85715e1050fa774c3267dbbe2f749717aeeec8ff 
(about 2 weeks old) into premain.

- Ioi

On 9/22/25 1:08 PM, Vladimir Kozlov wrote:
> JDK-8361376 removed WXWrite from 
> BarrierSetNMethod::nmethod_stub_entry_barrier() because it does not 
> modify nmethod directly in mainline. In leyden repo we do modify it.
>
> Putting it back to leyden code solved the issue:
>
> src/hotspot/share/gc/shared/barrierSetNMethod.cpp
> @@ -205,6 +205,7 @@ int 
> BarrierSetNMethod::nmethod_stub_entry_barrier(address* 
> return_address_ptr) {
>    }
>
>    if (may_enter) {
> +    MACOS_AARCH64_ONLY(ThreadWXEnable wx(WXWrite, Thread::current()));
>      nm->set_used();
>    } else {
>      log_trace(nmethod, barrier)("Deoptimizing nmethod: " PTR_FORMAT, 
> p2i(nm));
>
> Vladimir K
>
> On 9/22/25 10:35 AM, Vladimir Kozlov wrote:
>> Before you jump on it. Let me investigate this first to get more 
>> details.
>>
>> I am working on merge of latest mainline into leyden repo.
>>
>> Vladimir K
>>
>> On 9/22/25 12:37 AM, Andrew Haley wrote:
>>> On 22/09/2025 01:04, ioi.lam at oracle.com wrote:
>>>> Hi Andrew, do you know why we are seeing the crash in leyden but 
>>>> not in
>>>> mainline?
>>>
>>> No. If you let me have your merged tree I'll have a look.
>>>
>>
>