RFR: Minor cleanup and refactoring

[Ashutosh Mehra]

On Fri, 26 Sep 2025 20:04:20 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

> Removed unused parameter `aot_code_entry` in `ciEnv::register_method`.
> Removed `preload` local variable in `ciEnv::register_method` as it is always false.
> Refactored `ciEnv::is_compilation_valid` a bit.

src/hotspot/share/ci/ciEnv.cpp line 1003:

> 1001:     //  - AOTCodeCache is closed, AOTCode entry is garbage.
> 1002:     //  - AOTCode entry indicates this shared code was marked invalid while it was loaded.
> 1003:     if (!AOTCodeCache::is_on() || aot_code_entry->not_entrant()) {

We don't need to check for `AOTCodeCache::is_on` anymore because AOTCodeCache won't be closed if there are nmethod readers. See `AOTCodeCache::wait_for_no_nmethod_readers`.

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/101#discussion_r2383480628