RFR: 8377339: Implement AOTCacheAccess::get_archived_object using heap roots [v2]

[Ioi Lam]

On Fri, 6 Feb 2026 20:54:18 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - @DanHeidinga review comment
>>  - @DanHeidinga review comment
>>  - @DanHeidinga review comment
>>  - fixed typo
>
> src/hotspot/share/cds/heapShared.cpp line 256:
> 
>> 254: //   copying the objects into the cache. This will allow the hashcode to be
>> 255: //   dynamically and randomly computed in each production, which generally
>> 256: //   desirable for security reasons.
> 
> Suggestion:
> 
> //   desirable to make the hashcodes more random between runs.

Fixed.

> src/hotspot/share/cds/heapShared.cpp line 2468:
> 
>> 2466: 
>> 2467:   ResourceMark rm;
>> 2468:   int len;
> 
> Suggestion:
> 
>   int len = 0;
> 
> Nitpick: default values make the code easier to reason about.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/leyden/pull/108#discussion_r2783725331
PR Review Comment: https://git.openjdk.org/leyden/pull/108#discussion_r2783728469