<div dir="ltr">Ioi, thanks for updating <a href="https://bugs.openjdk.org/browse/JDK-8338476">https://bugs.openjdk.org/browse/JDK-8338476</a>, looks great.<div><br></div><div>John, thanks for your feedback, I indeed see how it could go wrong if you introduce some properties or APIs that allow to differentiate training from deployment runs without any control. If I take a step back, our main need is to get a boolean status that indicated if an AOT cache is being recorded or used, without needing to differentiate training from deployment runs (the use case here is to disable Spring Boot BackgroundPreinitializer when AOT cache is enabled regardless of the kind of run).</div><div><br></div><div>A potential future additional need would be to provide the capability to run additional code only during the training run, maybe via a lambda parameter (the use case here is to preload some additional classes or to perform additional processing to warm up the JVM when the -Dspring.context.exit=onRefresh flag documented in <a href="https://docs.spring.io/spring-framework/reference/integration/cds.html">https://docs.spring.io/spring-framework/reference/integration/cds.html</a> is used). But I am less confident on that use case that probably deserves more concrete use cases and experimentation.</div><div><br></div><div>So I think for now our ask is only about this undifferentiated boolean flag (property or API) that would be true if "-XX:AOTMode=record/autocreate/on/auto" is set.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 8, 2024 at 6:46 AM <<a href="mailto:ioi.lam@oracle.com">ioi.lam@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
On 10/7/24 3:29 PM, John Rose wrote:<br>
> On 4 Oct 2024, at 3:29, Sebastien Deleuze wrote:<br>
><br>
><br>
>> Side note: we really hope that a "-XX:CacheDataStore=app.cds" successor<br>
>> will be introduced because it really helps to not have to change the java<br>
>> command line between training and deployment runs for some deployment<br>
>> scenarios.<br>
> We should have a tracking RFE for this; I think Ioi<br>
> might have one.<br>
><br>
> — John<br>
<br>
<br>
I updated <a href="https://bugs.openjdk.org/browse/JDK-8338476" rel="noreferrer" target="_blank">https://bugs.openjdk.org/browse/JDK-8338476</a> to include two <br>
variants<br>
of creating Leyden-enabled AOT caches:<br>
<br>
[1] Identical replacement of the -XX:CacheDataStore flag (aka "one step <br>
workflow",<br>
where the AOT cache is created with a single "java" command).<br>
<br>
java -XX:CacheDataStore=app.cds -cp app.jar App<br>
=><br>
java -XX:AOTMode=autocreate -XX:AOTCache=app.aot -cp app.jar App<br>
<br>
- If app.aot exists, it will be used to run the application<br>
- Otherwise, app.aot will be created when the application exits<br>
<br>
[2] "Two step work flow" (as proposed in JEP 483), where two "java" <br>
commands are<br>
executed: one to perform the training run, the other to perform the <br>
assembly phase.<br>
<br>
java -XX:AOTMode=record -XX:AOTConfiguration=foo.aotconfig -cp <br>
app.jar App<br>
java -XX:AOTMode=create -XX:AOTConfiguration=foo.aotconfig <br>
-XX:AOTCache=foo.aot -cp app.jar<br>
<br>
</blockquote></div>
<br>
<span style="background-color:rgb(255,255,255)"><font size="2">This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.</font></span>