[master] RFR: Load Klass from header, C1/x86 implementation [v8]

Roman Kennke rkennke at openjdk.java.net
Tue Dec 14 17:01:21 UTC 2021


> This implements loading the Klass* from object header (instead of dedicated Klass* field) in C1 generated code. It introduces a new C1 LIR opcode (LoadKlass) and related CodeStub for the slow-path runtime-call.
> 
> The original implementation was brittle in that it emits the decode_klass() whenever it encounters a load that is T_ADDRESS and from klass_offset_in_bytes() (e.g. 4 or 8). Lucky that we did not seem to emit any unrelated such loads. This new implementation uses a dedicated C1 op instead, and expands this to the corresponding load of the header word, and call into slow-path upon fast-path-failure, in the LIR assembler.
> 
> Testing:
>  - [x] tier1 (x86_64,x86_32)
>  - [x] tier2 (x86_64,x86_32)
>  - [x] tier3 (x86_64,x86_32)
>  - [ ] tier4 (x86_64,x86_32)

Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:

  Allocate load-klass result register properly, avoid shuffling tricks

-------------

Changes:
  - all: https://git.openjdk.java.net/lilliput/pull/20/files
  - new: https://git.openjdk.java.net/lilliput/pull/20/files/6b24f6c6..e4dee271

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=lilliput&pr=20&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=lilliput&pr=20&range=06-07

  Stats: 19 lines in 6 files changed: 6 ins; 9 del; 4 mod
  Patch: https://git.openjdk.java.net/lilliput/pull/20.diff
  Fetch: git fetch https://git.openjdk.java.net/lilliput pull/20/head:pull/20

PR: https://git.openjdk.java.net/lilliput/pull/20


More information about the lilliput-dev mailing list