[master] RFR: Fix use of Klass* in GC JFR reporting

Aleksey Shipilev shade at openjdk.java.net
Tue Oct 12 12:26:18 UTC 2021


On Tue, 12 Oct 2021 11:37:04 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Some JFR related code paths in GC access the Klass* of old objects that has already been overidden by the forwarding pointer. We can easily use the Klass* that we fetched earlier instead.
> 
> Testing:
>  - [x] tier1
>  - [x] tier2
>  - [x] jdk/jfr (some of which still fails, see subsequent PRs)

Looks fine.

src/hotspot/share/gc/g1/g1ParScanThreadState.cpp line 387:

> 385: NOINLINE
> 386: HeapWord* G1ParScanThreadState::allocate_copy_slow(G1HeapRegionAttr* dest_attr,
> 387:                                                    oop old, Klass* klass,

Suggestion:

                                                   oop old, 
                                                   Klass* klass,


Looks like the style is one argument per line.

src/hotspot/share/gc/g1/g1ParScanThreadState.hpp line 161:

> 159: 
> 160:   HeapWord* allocate_copy_slow(G1HeapRegionAttr* dest_attr,
> 161:                                oop old, Klass* klass,

Suggestion:

                               oop old, 
                               Klass* klass,

-------------

Marked as reviewed by shade (Committer).

PR: https://git.openjdk.java.net/lilliput/pull/17


More information about the lilliput-dev mailing list