[master] RFR: Simplify stable_mark() routine [v2]

Roman Kennke rkennke at openjdk.java.net
Thu Apr 14 09:47:44 UTC 2022


On Wed, 13 Apr 2022 09:36:31 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> src/hotspot/share/runtime/synchronizer.cpp line 852:
>> 
>>> 850:       object->release_set_mark(mark);
>>> 851: 
>>> 852:       return dmw;
>> 
>> Question, why is above guarantee a guarantee, not an assert? You want to be super sure here also in release builds? Do you plan to drop down to assert() eventually?
>
> TBH, dunno really. This code originates from ObjectSynchronizer::inflate() and we can probably turn it into an assert.

I changed the guarantee to an assert, and will integrate as soon as GHA becomes green, unless you have objections.

-------------

PR: https://git.openjdk.java.net/lilliput/pull/46


More information about the lilliput-dev mailing list