[master] RFR: Relax array elements alignment [v5]

Roman Kennke rkennke at openjdk.java.net
Tue Apr 26 13:05:19 UTC 2022


On Tue, 26 Apr 2022 07:35:40 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use correct array element type to determine header size in TypeAryPtr::dump2()
>
> src/hotspot/share/oops/arrayOop.hpp line 132:
> 
>> 130:   // Returns the header size in bytes aligned to the requirements of the
>> 131:   // array object type.
>> 132:   static int header_size_in_bytes(BasicType type) {
> 
> Side remark, I wonder whether "first_element_offset" or something similar would not be more descriptive.

I'll use base_offset_in_bytes(BasicType) -- this already exists and simply calls header_offset_in_bytes(BasicType). It makes sense to unify them, and base_offset* is also used elsewhere in similar contexts.

-------------

PR: https://git.openjdk.java.net/lilliput/pull/41


More information about the lilliput-dev mailing list