[master] Integrated: Load Klass* from header, C2 implementation
Roman Kennke
rkennke at openjdk.java.net
Wed Feb 16 11:28:22 UTC 2022
On Thu, 25 Nov 2021 17:39:43 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
> This implements loading the compressed Klass* from the object header in C2.
> This is quite a hack: normally we should change the load offset everywhere in C2 from 8 (current klass_offset_in_bytes) to 0 (the mark word offset). However, offset = 0 has different meaning in C2, it means no offset, and throws off all sorts of stuff in C2. Realistically, in the long run, we want to change to loading from offset 4 (upper half of the header), but we currently need to deal with locking, and thus load from offset 0.
>
> I fake it: I pretend to load from offset 4 everywhere in C2 ideal graph, but then load from offset 0 and check the mark bits instead. We can't leave the offset in ideal graph at 8 because that is going to conflict with loads from first field as soon as we drop the Klass*.
>
> We also need to ensure that C2 knows that the condition flags are clobbered (cr), and that src and dst are not the same register.
>
> Testing:
> - [x] tier1 (x86_64, aarch64)
> - [x] tier2 (x86_64, aarch64)
> - [x] tier3 (x86_64, aarch64)
This pull request has now been integrated.
Changeset: 9c474685
Author: Roman Kennke <rkennke at openjdk.org>
URL: https://git.openjdk.java.net/lilliput/commit/9c47468527d4b81180a284d0b1367d91fe49ed50
Stats: 51 lines in 16 files changed: 13 ins; 3 del; 35 mod
Load Klass* from header, C2 implementation
Reviewed-by: shade
-------------
PR: https://git.openjdk.java.net/lilliput/pull/29
More information about the lilliput-dev
mailing list