[master] RFR: 8314130: [Lilliput] Make loadNKlassCompactHeaders not use a TEMP register

[Aleksey Shipilev]

On Thu, 10 Aug 2023 21:57:14 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> The loadNKlassCompactHeaders template in the .ad files currently declares dst as TEMP_DEF. This has historic reasons: We needed to ensure that dst doesn't overlap with src, because we needed src for calling into the slow-path. In addition to that, there seems to be a related bug in C2's matcher which sometimes seems to create an oopmap entry for a temp reg, which would make GCs crash if they scan uninitialized slot (see [JDK-8051805](https://bugs.openjdk.org/browse/JDK-8051805)). That problem should also go away with this change. In addition to that, relaxing the type of dst might also lead to performance enhancements when register pressure is high, because we don't need two registers for loadNKlass - 1 register would be enough.
> 
> Testing:
> - [x] tier1 +UseCompactObjectHeaders (x86_64, aarch64)
> - [x] tier2 +UseCompactObjectHeaders (x86_64, aarch64)

Okay, this makes sense. 

GHA are broken, because we have not picked up stuff from upstream recently.

-------------

Marked as reviewed by shade (Committer).

PR Review: https://git.openjdk.org/lilliput/pull/102#pullrequestreview-1573278708