[master] Integrated: JDK-8301786: [Lilliput] Failing CompressedClassPointerEncoding.java
Thomas Stuefe
stuefe at openjdk.org
Tue Feb 7 07:10:59 UTC 2023
On Mon, 6 Feb 2023 16:16:13 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> This fixes and expands runtime/CompressedOops/CompressedClassPointerEncoding.java.
>
> Test had been broken by integration of [JDK-8294677](https://bugs.openjdk.org/browse/JDK-8294677), but to my embarrassment, I found that the test had never actually been finished, some vital checks were missing.
>
> I fixed all that, clarified comments, and also changed the test to have multiple sub tests. I manually tested on x64 and aarch64.
>
> On aarch64, I tried to test both `xor` and `movk` encoding modes but was unable to test latter - the lowest valid encoding base that would trigger `movk` mode is `0xa00_00000000`, and the kernel on my Raspi box is compiled for max. 39 bits for virtual user space addresses. That makes mapping at higher addresses fail. See comment in test.
>
> There is more work to be done for aarch64: runtime/CompressedOops/CompressedClassPointerEncoding.java asserts. I opened https://bugs.openjdk.org/browse/JDK-8301880 to track that.
This pull request has now been integrated.
Changeset: 14672c69
Author: Thomas Stuefe <stuefe at openjdk.org>
URL: https://git.openjdk.org/lilliput/commit/14672c69ac527179baa28396bcd75dee20170cf3
Stats: 318 lines in 1 file changed: 198 ins; 54 del; 66 mod
8301786: [Lilliput] Failing CompressedClassPointerEncoding.java
Reviewed-by: shade
-------------
PR: https://git.openjdk.org/lilliput/pull/72
More information about the lilliput-dev
mailing list