[master] RFR: 8302065: [Lilliput] Cleanups and touch-ups [v2]

Roman Kennke rkennke at openjdk.org
Thu Feb 9 10:37:56 UTC 2023


On Thu, 9 Feb 2023 09:35:03 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove newline
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 109:
> 
>> 107: 
>> 108:  private:
>> 109: 
> 
> Missed a similar cleanup in `macroAssembler_x86.hpp`, I think.

Right. I removed the newline in that file, too.

> src/hotspot/cpu/x86/vtableStubs_x86_64.cpp line 220:
> 
>> 218:   // The emitted code in lookup_interface_method changes when itable_index exceeds 15.
>> 219:   // For linux, a very narrow estimate would be 112, but Solaris requires some more space (130).
>> 220:   const ptrdiff_t estimate = 137;
> 
> Upstream has it as `136`. Do we need `137`?

I couldn't build/run it with 136, it asked for 137. *shrugs*

-------------

PR: https://git.openjdk.org/lilliput/pull/73


More information about the lilliput-dev mailing list