[master] RFR: 8300573: [Lilliput] Properly set ZF on anon-check path; avoid some conditional branches

Aleksey Shipilev shade at openjdk.org
Fri Jan 20 16:04:44 UTC 2023


On Wed, 18 Jan 2023 17:11:02 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> In AArch64's fast_unlock(), we need to check if the monitor owner is ANONYMOUS (only with Lilliput/fast-locking), and if so, call the runtime to fix this before exiting the monitor. I tried to be smart and used tbnz there, but it turns out that tbnz does *not* set the zero flag, but we do need the ZF set correctly on exit of fast_unlock, so that C2 generated code would actually call the slow path. Therefore we need to use the longer tst/br instructions instead.
> 
> The change also removes some conditional branches.
> 
> All of the changes have already been integrated into the upstream proposed PR: https://github.com/openjdk/jdk/pull/10907/
> 
> Testing:
>  - [x] tier1
>  - [x] tier2

Uff. `cont` and `count` look cunningly similar. Anyway!

-------------

Marked as reviewed by shade (Committer).

PR: https://git.openjdk.org/lilliput/pull/63


More information about the lilliput-dev mailing list