[master] RFR: 8300527: [Lilliput] Simplify and optimize loading of Klass* [v2]

[Roman Kennke]

On Tue, 24 Jan 2023 16:56:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use _stub instead of stub()
>
> src/hotspot/share/c1/c1_LIR.cpp line 891:
> 
>> 889:       do_input(opLoadKlass->_obj);
>> 890:       do_output(opLoadKlass->_result);
>> 891:       do_stub(opLoadKlass->stub());
> 
> Minor: why not leave `_stub`?

Right. I changed that back.

> src/hotspot/share/runtime/synchronizer.cpp line 798:
> 
>> 796: static SharedGlobals GVars;
>> 797: 
>> 798: static markWord read_stable_mark(oop obj) {
> 
> Do you still need this method, or? If you still need it, let's not put it outside the `ObjectSynchronizer` "namespace".

Originally, read_stable_mark() is static in upstream. A while back I put it into the ObjectSynchronizer namespace to reuse it in Shenandoah, but that is no longer needed, so I reverted the scope back to compilation-unit-private. Yes, we will still need it, when we make Lilliput switchable, but I'd keep it compilation-unit-private for the reasons mentioned.

-------------

PR: https://git.openjdk.org/lilliput/pull/66