[master] RFR: 8301545: [Lilliput] Fix aarch64 interpreter load_nklass()
Aleksey Shipilev
shade at openjdk.org
Tue Jan 31 14:11:41 UTC 2023
On Tue, 31 Jan 2023 13:54:52 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
> In #66 I made a mistake in a last-minute change and GHA hasn't caught it: I got a condition wrong. Let's fix it.
>
> Testing:
> - [x] tier1
> - [ ] tier2
I remember looking at this during the original review, and I managed to convince myself `NE` is correct. But looking at it again, I think I flipped the meaning of ZF in my head.
Suppose the "monitor" bit is set in the mark. Then `tst` effectively ands and gets non-zero result, which sets internal ALU flag Z=0. Then `NE` checks for `Z=0` and branches to `fast`. This is not what we want, we instead want to go `EQ`, check for `Z=1` and branch to `fast` then.
-------------
Marked as reviewed by shade (Committer).
PR: https://git.openjdk.org/lilliput/pull/68
More information about the lilliput-dev
mailing list