[lilliput-jdk17u:lilliput] RFR: 8309192: [Lilliput/JDK17] Properly deal with flag mismatch in CDS [v2]

Aleksey Shipilev shade at openjdk.org
Thu Jun 1 12:51:29 UTC 2023


On Thu, 1 Jun 2023 12:25:11 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Cherry-pick
>>  - Revert old patch
>
> test/hotspot/jtreg/runtime/cds/CdsDifferentCompactObjectHeaders.java line 50:
> 
>> 48:     // Parameters are object alignment expressed in bytes
>> 49:     private static void
>> 50:     createAndLoadSharedArchive(boolean createCompactHeaders, boolean loadCompactHeaders)
> 
> Small nit, weird naming. Proposal:  `s/createCompactHeaders/useCOHOnCreate` or similar, same for Load

This is from mainline, so I'd like to match.

-------------

PR Review Comment: https://git.openjdk.org/lilliput-jdk17u/pull/29#discussion_r1213101493


More information about the lilliput-dev mailing list