[lilliput-jdk17u:lilliput] RFR: 8310156: [Lilliput/JDK17] Specialize full-GC loops [v2]

Aleksey Shipilev shade at openjdk.org
Tue Jun 20 09:00:32 UTC 2023


On Mon, 19 Jun 2023 14:54:09 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1FullGCAdjustTask.cpp line 111:
>> 
>>> 109:   marker->preserved_stack()->adjust_during_full_gc();
>>> 110: 
>>> 111:   G1AdjustClosure<ALT_FWD> adjust(collector());
>> 
>> Make a concession for code style, and name this local `_adjust`? Would save the renames everywhere else.
>
> I would keep the _adjust -> adjust renaming changes as they are. I make this change once (or twice, again when actually upstreaming), but it's going to raise eyebrows whenever somebody reads this code.

Okay. I was mostly concerned about the future backports in the adjacent code, but those conflict would likely be resolvable without much of a problem.

-------------

PR Review Comment: https://git.openjdk.org/lilliput-jdk17u/pull/32#discussion_r1234960265


More information about the lilliput-dev mailing list