[lilliput-jdk17u:lilliput] RFR: 8310642: [Lilliput/JDK17] Remove unnecessary check in G1ParScanThreadState

Aleksey Shipilev shade at openjdk.org
Thu Jun 22 12:06:41 UTC 2023


On Thu, 22 Jun 2023 11:51:39 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> G1ParScanThreadState::do_copy_to_survivor_space() has an unnecessary change against upstream:
> 
>  if (old_mark.is_marked()) {
>     // Already forwarded by somebody else, return forwardee.
>     return old->forwardee(old_mark);
>   }
> 
> All callers of this method already do the same, so this only adds code and possible affects performance for no reason.
> 
> Testing:
>  - [ ] hotspot_gc -UCOH
>  - [ ] hotspot_gc +UCOH
>  - [ ] tier1 -UCOH
>  - [ ] tier1 +UCOH
>  - [ ] tier2 -UCOH
>  - [ ] tier2 +UCOH

This looks good, thanks.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/lilliput-jdk17u/pull/42#pullrequestreview-1493035324


More information about the lilliput-dev mailing list